Replace Papa SafeTrace with androidx.tracing #1429
Merged
+12
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependency on papa.SafeTrace and replace it with
androidx.tracing.Trace. This simplifies the dependency tree by
using the standard AndroidX tracing library instead of the
third-party Papa library. (Note: we have a test-only dependency on Papa
still for papa.Choreographers)
The PapaSafeTrace class now delegates to androidx.tracing.Trace
methods which provide equivalent functionality. The isCurrentlyTracing
property now uses Trace.isEnabled() instead of
SafeTrace.isCurrentlyTracing, and logSection() now uses the trace {}
inline function from androidx.tracing.ktx.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
steve-the-edwards
approved these changes
Nov 11, 2025
| */ | ||
| class PapaSafeTrace( | ||
| override val isTraceable: Boolean = false | ||
| ) : SafeTraceInterface { |
Contributor
There was a problem hiding this comment.
Let's rename this class then as it no longer uses Papa
Collaborator
Author
There was a problem hiding this comment.
Yep, totally. I'll prepare a separate PR to do so. How about s/PapaSafeTrace/WorkflowTrace and s/SafeTraceInterface/TraceInterface?
|
|
||
| override val isCurrentlyTracing: Boolean | ||
| get() = SafeTrace.isCurrentlyTracing | ||
| get() = Trace.isEnabled() |
Contributor
There was a problem hiding this comment.
Does isEnabled go off and on based on whether we are actively recording a trace?
tcmulcahy
merged commit 42f75b5
into
tomm/remove-safe-trace-is-traceable
198 of 203 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on papa.SafeTrace and replace it with androidx.tracing.Trace. This simplifies the dependency tree by using the standard AndroidX tracing library instead of the third-party Papa library. (Note: we have a test-only dependency on Papa still for papa.Choreographers)
The PapaSafeTrace class now delegates to androidx.tracing.Trace methods which provide equivalent functionality. The isCurrentlyTracing property now uses Trace.isEnabled() instead of
SafeTrace.isCurrentlyTracing, and logSection() now uses the trace {} inline function from androidx.tracing.ktx.